-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added href property to sideNavMenuItem #16113
fix: added href property to sideNavMenuItem #16113
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The ci / test
check is failing because the public api snapshot is out of date. You can update it with yarn test -u
and push up the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know once those tests are updated and I can take another look :)
4633e13
* fix: added href property to sideNavMenuItem * fix: updated snapshots * chore: update snapshots --------- Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com> Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>
Closes #15580
Added optional prop href to SideNavMenuItem
Changelog
New
Testing / Reviewing
Test SideNavMenuItem with href property in typescript environment. Verify that the TypeScript compiler should not throw error and the component renders without errors and correctly applies the provided href attribute.